NickAkhmetov/CAT-435 disable scrolling full page when using arrow keys to explore Vitessce visualizations #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vitessce visualization
john-conroy
approved these changes
Oct 7, 2024
NickAkhmetov
deleted the
nickakhmetov/cat-435-page-scrolling-in-vitessce-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the Visualization Tracker to prevent default behaviors for arrow key events when the user has the vitessce visualization focused. This keeps the visualization in place while the user adjusts e.g. the position of a scatterplot or spatial view.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-435
Testing
Manually tested; see video below.
Screenshots/Video
In this video, I switch between the same dataset on production and on my local environment to compare the behaviors before and after these changes.
Screen.Recording.2024-10-07.121909.mp4
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes